Support only latest PyNWB #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO in follow-up: re-implement #265 |
3 tasks
stephprince
reviewed
Sep 16, 2024
Co-authored-by: Steph Prince <[email protected]>
stephprince
approved these changes
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #510 +/- ##
==========================================
+ Coverage 79.53% 85.03% +5.50%
==========================================
Files 48 48
Lines 1412 1390 -22
==========================================
+ Hits 1123 1182 +59
+ Misses 289 208 -81
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per previous discussion about what range of support NWB Inspector ought to have with past PyNWB/HDMF versions - we decided it should only support latest
This simplifies a lot of conditions on the core inspection logic, individual checks, and what the testing suite is responsible for checking
The only aspect that cannot be replaced is using old versions of PyNWB to generate example files with particular failures that are no longer possible to achieve in latest PyNWB - these are still good to check the inspection logic on since someone could write a file using an older version but inspect it in a different environment (DANDI validate/upload would outright require that) - so I'm keeping those helpers around